deps: Upgrade date-fns to v2.29.3 #2522
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to use the `add` and `sub` functions that are not available
in v1.30.1.
Since there's a large gap between the two versions, we have a lot of
modifications to accomodate API changes:
- imports of functions whose names are made of multiple words have
changed from a snake case format to a camel case one
- locales are not exposed as separate modules anymore; they need to be
imported from `date-fns/locales`
- the format used by `format()` and `parse()` is now based on Unicode
Technical Standard #35 (see https://www.unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table)
with a few additions (see https://date-fns.org/v2.29.3/docs/format)
→ `YYYY` becomes `yyyy`
→ `D` becomes `d`
→ `DD` becomes `dd`
→ `ddd` becomes `EEE`
→ the escape character is now `'` (single quote) instead of `[`
- all `date-fns` functions now require arguments to be `Date` objects
or numbers and do not accept strings anymore. Therefore, all
date strings are now parsed before being passed as `date-fns`
function arguments and all test data mocks have been updated to use
only ISO formatted date strings
- `isWithinRange` becomes `isWithinInterval` which is inclusive
(i.e. `isWithinRange(3, 1, 3) === false` vs
`isWithinInterval(3, { start: 1, end: 3 }) === true`)
|
This PR is waiting for other libraries to upgrade |
Base automatically changed from
fix/prevent-excessive-konnector-alerts-notifications
to
master
October 12, 2022 07:43
PolariTOON
reviewed
Dec 8, 2022
| import frLocale from 'date-fns/locale/fr' | ||
| import enLocale from 'date-fns/locale/en' | ||
| import esLocale from 'date-fns/locale/es' | ||
| import { fr as frLocale, en as enLocale, es as esLocale } from 'date-fns/locale' |
There was a problem hiding this comment.
This version of date-fns does not export any en locale anymore. You likely want enUS instead.
|
We have a webpack config in this app that defines a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to use the
addandsubfunctions that are not availablein v1.30.1.
Since there's a large gap between the two versions, we have a lot of
modifications to accommodate API changes:
changed from a snake case format to a camel case one
imported from
date-fns/localesformat()andparse()is now based on UnicodeTechnical Standard n°35 (see https://www.unicode.org/reports/tr35/tr35-dates.html#Date_Field_Symbol_Table)
with a few additions (see https://date-fns.org/v2.29.3/docs/format)
→
YYYYbecomesyyyy→
Dbecomesd→
DDbecomesdd→
dddbecomesEEE→ the escape character is now
'(single quote) instead of[date-fnsfunctions now require arguments to beDateobjectsor numbers and do not accept strings anymore. Therefore, all
date strings are now parsed before being passed as
date-fnsfunction arguments and all test data mocks have been updated to use
only ISO formatted date strings
isWithinRangebecomesisWithinIntervalwhich is inclusive(i.e.
isWithinRange(3, 1, 3) === falsevsisWithinInterval(3, { start: 1, end: 3 }) === true)