Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: packages/core/src/manager.ts - addChains function execution logic error fix. #471

Open
wants to merge 9 commits into
base: testing/mocks
Choose a base branch
from
Open

fix: packages/core/src/manager.ts - addChains function execution logic error fix. #471

wants to merge 9 commits into from

Conversation

willltns
Copy link

After calling the walletManager's addChains method, due to the findIndex logic problem, newChainRecords traverse always overwrites the first item in this.chainRecords. The same problem in the code below, when a new walletRepo is pushed to this.walletRepos.

@willltns
Copy link
Author

willltns commented Jun 16, 2024 •
edited
Loading

fix packages/core/src/manager.ts's bug, and implement the main functions of Mock Wallet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@willltns