Update go and golangci-lint #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaye81
force-pushed
the
sayers/update_go_1.22
branch
from
54cabe1
to
1a7525e
Compare
jhump
approved these changes
Sep 4, 2024
cmd/demoserver/main_test.go
Outdated
| @@ -70,13 +69,15 @@ func TestElizaServer(t *testing.T) { | |||
| stream := client.Converse(context.Background()) | |||
| var wg sync.WaitGroup | |||
| wg.Add(2) | |||
| errs := make(chan error, 4) | |||
There was a problem hiding this comment.
This would be much simpler to use an errgroup.Group instead of sync.WaitGroup and all of this error-tracking channel chicanery.
grp, ctx := errgroup.WithContext(context.Background())
// use ctx to start RPC ...
grp.Go(func() error {
// send messages, immediately return err on failure
// (instead of storing in channel)
})
grp.Go(func() error {
// receive messages, immediately return err on failure
})
require.NoError(t, grp.Wait())There was a problem hiding this comment.
Big fan of the line error-tracking channel chicanery.. Updated lmk what you think.
jhump
reviewed
Sep 4, 2024
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
Signed-off-by: Steve Ayers <[email protected]>
smaye81
force-pushed
the
sayers/update_go_1.22
branch
from
821a93b
to
12a9dde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that a new version of Go has been released, this bumps the versions used in this repo.
This also updates golangci-lint to the latest, which called for some config changes to eliminate warnings.