Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SSL registry #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

beeender
Copy link
Contributor

  • Add option 'ssl.ca.location', 'ssl.certificate.location',
    'ssl.key.location' and 'ssl.enabled.min_protocol' to support SSL
    enabled registry service.

Limitations:

  • 'schema.registry.url' accepts multiple URLs separated by ','. But
    the options added by this commit don't. That means all the URLs will
    use the same SSL information provided by those options.

Close #7

- Add option 'ssl.ca.location', 'ssl.certificate.location',
  'ssl.key.location' and 'ssl.enabled.min_protocol' to support SSL
  enabled registry service.

Limitations:
- 'schema.registry.url' accepts multiple URLs separated by ','. But
  the options added by this commit don't. That means all the URLs will
  use the same SSL information provided by those options.

Close confluentinc#7
@beeender
Copy link
Contributor Author

BTW, I noticed this may not be the direction of #36 . It would be really good if the refactor work of #36 could handle the SSL connection.

@edenhill
Copy link
Contributor

[clabot:check]

@ghost
Copy link

ghost commented Apr 30, 2021

@confluentinc It looks like @beeender just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@jarrodu
Copy link

jarrodu commented Jan 7, 2022

Any word on this?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@alecbcs
Copy link

alecbcs commented Jan 23, 2024

Hi all, is this PR still waiting on @beeender to sign the license agreement? Supporting SSL registries would be hugely helpful.

@beeender
Copy link
Contributor Author

Hi all, is this PR still waiting on @beeender to sign the license agreement? Supporting SSL registries would be hugely helpful.

I did! 😄

Copy link

@vdeters vdeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libserdes self signed certificate path
6 participants