[KIP-848] Tests for ListGroups filter to list only given group types

Co-authored-by: mahajanadhitya <[email protected]>
confluentinc · Oct 3, 2024 · 0550863 · 0550863
1 parent a77f9f2
commit 0550863
Show file tree

Hide file tree

Showing 2 changed files with 213 additions and 129 deletions.
diff --git a/tests/0080-admin_ut.c b/tests/0080-admin_ut.c
@@ -528,22 +528,44 @@ static void do_test_ListConsumerGroups(const char *what,
         q = useq ? useq : rd_kafka_queue_new(rk);
 
         if (with_options) {
-                rd_kafka_consumer_group_state_t duplicate[2] = {
+                rd_kafka_error_t *error;
+                rd_kafka_consumer_group_state_t duplicate_states[2] = {
                     RD_KAFKA_CONSUMER_GROUP_STATE_EMPTY,
                     RD_KAFKA_CONSUMER_GROUP_STATE_EMPTY};
+                rd_kafka_consumer_group_type_t duplicate_types[2] = {
+                    RD_KAFKA_CONSUMER_GROUP_TYPE_CLASSIC,
+                    RD_KAFKA_CONSUMER_GROUP_TYPE_CLASSIC};
+                rd_kafka_consumer_group_type_t unknown_type[1] = {
+                    RD_KAFKA_CONSUMER_GROUP_TYPE_UNKNOWN};
 
                 options = rd_kafka_AdminOptions_new(
                     rk, RD_KAFKA_ADMIN_OP_LISTCONSUMERGROUPS);
 
                 /* Test duplicate error on match states */
-                rd_kafka_error_t *error =
-                    rd_kafka_AdminOptions_set_match_consumer_group_states(
-                        options, duplicate, 2);
+                error = rd_kafka_AdminOptions_set_match_consumer_group_states(
+                    options, duplicate_states, 2);
                 TEST_ASSERT(error && rd_kafka_error_code(error), "%s",
                             "Expected error on duplicate states,"
                             " got no error");
                 rd_kafka_error_destroy(error);
 
+                /* Test duplicate error on match group types */
+                error = rd_kafka_AdminOptions_set_match_consumer_group_types(
+                    options, duplicate_types, 2);
+                TEST_ASSERT(error && rd_kafka_error_code(error), "%s",
+                            "Expected error on duplicate group types,"
+                            " got no error");
+                rd_kafka_error_destroy(error);
+
+                /* Test invalid args error on setting UNKNOWN group type in
+                 * match group types */
+                error = rd_kafka_AdminOptions_set_match_consumer_group_types(
+                    options, unknown_type, 1);
+                TEST_ASSERT(error && rd_kafka_error_code(error), "%s",
+                            "Expected error on Unknown group type,"
+                            " got no error");
+                rd_kafka_error_destroy(error);
+
                 exp_timeout = MY_SOCKET_TIMEOUT_MS * 2;
                 TEST_CALL_ERR__(rd_kafka_AdminOptions_set_request_timeout(
                     options, exp_timeout, errstr, sizeof(errstr)));