Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#538 - LOG_DIR not set causing FileNotFoundException #688

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MarkC0x
Copy link

@MarkC0x MarkC0x commented Jun 3, 2020

Noticed that this same LOG_DIR not set causing FileNotFoundException behavior was still happening in the latest 5.5.x version of Rest Proxy.

Created a simple PR to correctly set the base log directory for the logs.

@ghost
Copy link

ghost commented Jun 3, 2020

@confluentinc It looks like @MarkC0x just signed our Contributor License Agreement. 👍

Always at your service,

clabot

@@ -39,6 +39,11 @@ if [ "x$KAFKAREST_LOG4J_OPTS" = "x" ]; then
fi
fi

# Log directory to use
if [ "x$LOG_DIR" = "x" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[[ -z "${LOG_DIR+x}" ]] && LOG_DIR="$base_dir/logs"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, not sure if $base_dir/logs is a better default log folder than, for example, /var/log/kafka-rest. AK uses /var/log/kafka by default, I think.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reviewing @rigelbm -- I used the same $base_dir/logs default folder code present in both AK and CP kafka-run-class files, so that things remained consistent. I can change the logic to your modified version though if you prefer?

Copy link

cla-assistant bot commented Sep 12, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Mark Cox seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants