Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base Firebird dialect implementation #1188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vasiliy-yashkov
Copy link

Problem

The current implementation of the kafka-connect-jdbc does not support the Firebird. It does not allow to use some features, i.e. upsert. In addition, the base dialect does not take into account the mapping between Firebird data types and Kafka schema types.

Solution

Creating a dialect for Firebird that implements and overrides basic features of the generic database dialect.

Does this solution apply anywhere else?
  • yes
  • no

Test Strategy

Several unit tests have been added to test the Firebird dialect. Manual testing was done with docker-compose, which was running kafka, connect-jdbc and the Firebird server. Testing was performed on Firebird 4.0.1 and Jaybird 4.0.5 for Java 11 / JDBC 4.3.

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

@vasiliy-yashkov vasiliy-yashkov requested a review from a team as a code owner April 18, 2022 13:50
@CLAassistant
Copy link

CLAassistant commented Apr 18, 2022

CLA assistant check
All committers have signed the CLA.

@vasiliy-yashkov
Copy link
Author

Hi all! Can anyone review?

@dieterrosch
Copy link

Anyone?

@nicpym-bbd
Copy link

Hi, I am running into the same timestamp issue, and this PR fixes that. Can anyone please review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants