Add base Firebird dialect implementation #1188
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current implementation of the
kafka-connect-jdbc
does not support theFirebird
. It does not allow to use some features, i.e.upsert
. In addition, the base dialect does not take into account the mapping betweenFirebird
data types andKafka
schema types.Solution
Creating a dialect for
Firebird
that implements and overrides basic features of the generic database dialect.Does this solution apply anywhere else?
Test Strategy
Several unit tests have been added to test the
Firebird
dialect. Manual testing was done with docker-compose, which was runningkafka
,connect-jdbc
and theFirebird
server. Testing was performed onFirebird 4.0.1
andJaybird 4.0.5 for Java 11 / JDBC 4.3
.Testing done: