Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index templates other than logs and metrics when using data streams #752

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxgruber19
Copy link

@maxgruber19 maxgruber19 commented Feb 19, 2024

index templates other than logs and metrics when using data streams #751

Problem

In most real world scenarios a user is not in control over the default index templates "logs" and "metrics". There are many usecases where the user wants to define a custom template. In my case I want to use the data retention feature to delete messages stored in elasticsearch after a certain amount of time.

Currently this connector is able to use the predefined index templates "logs" and "metrics" when data streams are enabled. User created templates are not supported yet.

Solution

Defining the type of the data stream as String to make it flexible for custom inputs. The enum will not be removed to still be able to use the recommender when deploying the connector via control-center.

Does this solution apply anywhere else?
  • yes
  • no

Test Strategy

Started a local cluster via docker-compose (cp-quickstart and elastic+kibana) and installed the connector.zip in the cluster. Both connectors with "logs" and connectors with "custom" as data stream types were running perfectly fine after creating the "custom" index template in Kibana.

Testing done:
  • Unit tests
  • Integration tests
  • System tests
  • Manual tests

Copy link

cla-assistant bot commented Feb 19, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Feb 19, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@maxgruber19 maxgruber19 marked this pull request as ready for review February 19, 2024 08:24
@maxgruber19 maxgruber19 requested a review from a team as a code owner February 19, 2024 08:24
@ge1sterfahrer
Copy link

Having this feature would massively help us in day to day business. What's your opinion on this? @sp-gupta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants