Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new vars for mtls ansieng 4229 (#53) #1794

Open
wants to merge 2 commits into
base: 7.8.x
Choose a base branch
from

Conversation

rrbadiani
Copy link
Member


Description

Add new variables for RBAC over mTLs

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • Any variable/code changes have been validated to be backwards compatible (doesn't break upgrade)
  • I have added tests that prove my fix is effective or that my feature works
  • If required, I have ensured the changes can be discovered by cp-ansible discovery codebase
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

* Bump cp-ansible Version: 7.6.2 → 7.6.3

* variables.md updated

* Bump CP Version: 7.4.6 → 7.4.7

* Bump cp-ansible Version: 7.4.6 → 7.4.7

* variables.md updated

* Bump CP Version: 7.5.5 → 7.5.6

* Bump cp-ansible Version: 7.5.5 → 7.5.6

* variables.md updated

* Bump CP Version: 7.3.9 → 7.3.10

* Bump cp-ansible Version: 7.3.10 → 7.3.11

* Bump Version: 7.1.13 → 7.1.14

* variables.md updated

* Bump Version: 7.2.11 → 7.2.12

* variables.md updated

* Bump Version: 7.0.15 → 7.0.16

* [ANSIENG-4224] | update CHANGELOG.rst (#41)

* [ANSIENG-4225] | update CHANGELOG.rst (#42)

* [ANSIENG-4226] | update CHANGELOG.rst (#43)

* [ANSIENG-4222] | update CHANGELOG.rst (#45)

* [ANSIENG-4221] | update CHANGELOG.rst (#46)

* [ANSIENG-4220] | update CHANGELOG.rst (#47)

* [ANSIENG-4219] | update CHANGELOG.rst (#48)

* [ANSIENG-4223] | update CHANGELOG.rst (#44)

* [ANSIENG-4223] | update CHANGELOG.rst

* [ANSIENG-4223] | update CHANGELOG.rst

* [ANSIENG-4229] | adding new user facing variables for rbac over mtls

* [ANSIENG-4229] | modifying the default values of ssl_client_authentication and ssl_mutual_auth

---------

Co-authored-by: ConfluentSemaphore <[email protected]>
Co-authored-by: Mansi Jain <[email protected]>
@rrbadiani rrbadiani requested a review from a team as a code owner September 26, 2024 05:57
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link

cla-assistant bot commented Sep 26, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
Copy link

cla-assistant bot commented Sep 26, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

{%- if ssl_mutual_auth_enabled|bool -%}
{%- if deployment_strategy == 'parallel' -%}
required
{%- elif deployment_strategy in ['serial', 'rolling'] -%}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not defined in case of deployment strategy serial/rolling then we should fail the setup

{%- endif -%}

# yamllint disable-line rule:key-duplicates
ssl_mutual_auth_enabled: "{{ true if ssl_client_authentication in ['required', 'requested'] else false }}"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in config validations check if user is defining both these in contrdictory way and stop the setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants