-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to wasmd 0.30.0-rc0 #479
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #479 +/- ##
=======================================
Coverage 56.67% 56.67%
=======================================
Files 73 73
Lines 5824 5831 +7
=======================================
+ Hits 3301 3305 +4
- Misses 2200 2203 +3
Partials 323 323
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did not add the ics29 fee middleware in this upgrade but this is ok for me.
The IBC v4 requires a migration when you skip the v2 release. Please add it to be on the safe side.
@@ -397,7 +397,7 @@ func NewTgradeApp( | |||
// Create static IBC router, add app routes, then set and seal it | |||
ibcRouter := porttypes.NewRouter() | |||
ibcRouter. | |||
AddRoute(wasm.ModuleName, wasm.NewIBCHandler(app.twasmKeeper, app.ibcKeeper.ChannelKeeper)). | |||
AddRoute(wasm.ModuleName, wasm.NewIBCHandler(app.twasmKeeper, app.ibcKeeper.ChannelKeeper, app.ibcKeeper.ChannelKeeper)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -3,10 +3,10 @@ module github.com/confio/tgrade | |||
go 1.18 | |||
|
|||
require ( | |||
github.com/CosmWasm/wasmd v0.29.1 | |||
github.com/CosmWasm/wasmd v0.30.0-rc0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrade wasmd to v0.30.0-rc0 and ibc to v4.2.0