-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Withdraw rewards ...
tests
#773
Conversation
# Conflicts: # cypress/steps-definition/MainMenu.ts # cypress/steps-definition/Validators.ts
# Conflicts: # cypress/steps-definition/Validators.ts # src/App/components/NavSidebar/index.tsx
…n-other-account # Conflicts: # cypress/steps-definition/Validators.ts # src/App/components/NavSidebar/index.tsx
Withdraw rewards to an other account
testWithdraw rewards
tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! I approve this PR but I set as "request changes" while the CI does not pass.
* Set existing "fourthMnemonic" wallet with Engagement Points and Engagement Rewards | ||
* I visit Engagement page | ||
* I enter existing "thirdAccount" address to initial Address field | ||
* I see my Engagement Points "3 / 2034 (0.15%)" and Engagement Rewards "6" TGD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I am not seeing "my" engagement points since it's thirdAccount and not fourthAccount we are querying.
I understand it's because the name of the test so it's ok, no worries. No need to change anything 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true i will add steps to check Engagement for fourthAccount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will update it soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to check for fourthAccount, I mean that the text says "I see my Engagement Points..." and you are not seeing your EP, you are seeing other account's EP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aaa this my
word is very specific will remove it to make more generic, good catch
@@ -0,0 +1,60 @@ | |||
import { Bip39, Random } from "@cosmjs/crypto"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very useful file, like existingAccounts.ts
. I think it would be more readable to use numbers instead of string ordinals randomMnemonicFourth -> randomMnemonic04
, but I don't mind you doing it this way if you prefer it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, let me update it
* Workaround to clear localstorage | ||
* I connect Web Demo wallet | ||
* Set existing "fourthMnemonic" wallet with Engagement Points and Engagement Rewards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes these 3 lines of code take hours of effort
cy.clearLocalStorage("pinned-tokens-map");
cy.clearLocalStorage("burner-wallet");
cy.clearLocalStorage("last-wallet");
I hope it will be stable in the future
#* I click on the "Withdraw rewards" button in the dialog | ||
#* I see Tx success screen with existing "node1Account" address | ||
#* I click Go to Engagement button | ||
|
||
# Check balance of initial account | ||
#TODO | ||
|
||
# Check balance of Receiver address | ||
#* I check that the other account's TGD balance has gone up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to say, that this test have not finished steps because we need validator with some Engagement points
closes: #772, #769, #790, #799, #802, #803, #804, #805, #807, #809