Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Withdraw rewards ... tests #773

Merged
merged 59 commits into from
Aug 25, 2022
Merged

Conversation

Ebazhanov
Copy link
Contributor

@Ebazhanov Ebazhanov commented Jul 15, 2022

closes: #772, #769, #790, #799, #802, #803, #804, #805, #807, #809

@Ebazhanov Ebazhanov added the E2E tests E2E tests label Jul 15, 2022
# Conflicts:
#	cypress/steps-definition/Validators.ts
#	src/App/components/NavSidebar/index.tsx
…n-other-account

# Conflicts:
#	cypress/steps-definition/Validators.ts
#	src/App/components/NavSidebar/index.tsx
@Ebazhanov Ebazhanov changed the title Withdraw rewards to an other account test Withdraw rewards tests Aug 10, 2022
@Ebazhanov Ebazhanov changed the title Withdraw rewards tests Withdraw rewards ... tests Aug 10, 2022
@Ebazhanov Ebazhanov marked this pull request as ready for review August 22, 2022 08:21
@Ebazhanov Ebazhanov removed the request for review from abefernan August 24, 2022 15:34
@Ebazhanov Ebazhanov marked this pull request as draft August 24, 2022 15:34
@Ebazhanov Ebazhanov marked this pull request as ready for review August 25, 2022 07:47
Copy link
Collaborator

@abefernan abefernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! I approve this PR but I set as "request changes" while the CI does not pass.

* Set existing "fourthMnemonic" wallet with Engagement Points and Engagement Rewards
* I visit Engagement page
* I enter existing "thirdAccount" address to initial Address field
* I see my Engagement Points "3 / 2034 (0.15%)" and Engagement Rewards "6" TGD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I am not seeing "my" engagement points since it's thirdAccount and not fourthAccount we are querying.
I understand it's because the name of the test so it's ok, no worries. No need to change anything 👍

Copy link
Contributor Author

@Ebazhanov Ebazhanov Aug 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true i will add steps to check Engagement for fourthAccount

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update it soon

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to check for fourthAccount, I mean that the text says "I see my Engagement Points..." and you are not seeing your EP, you are seeing other account's EP

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aaa this my word is very specific will remove it to make more generic, good catch

@@ -0,0 +1,60 @@
import { Bip39, Random } from "@cosmjs/crypto";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful file, like existingAccounts.ts. I think it would be more readable to use numbers instead of string ordinals randomMnemonicFourth -> randomMnemonic04, but I don't mind you doing it this way if you prefer it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let me update it

Comment on lines +28 to +30
* Workaround to clear localstorage
* I connect Web Demo wallet
* Set existing "fourthMnemonic" wallet with Engagement Points and Engagement Rewards
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes these 3 lines of code take hours of effort

  cy.clearLocalStorage("pinned-tokens-map");
  cy.clearLocalStorage("burner-wallet");
  cy.clearLocalStorage("last-wallet");

I hope it will be stable in the future

@Ebazhanov Ebazhanov merged commit 1ef0d01 into main Aug 25, 2022
@Ebazhanov Ebazhanov deleted the withdraw-rewards-to-an-other-account branch August 25, 2022 15:14
Comment on lines +24 to +32
#* I click on the "Withdraw rewards" button in the dialog
#* I see Tx success screen with existing "node1Account" address
#* I click Go to Engagement button

# Check balance of initial account
#TODO

# Check balance of Receiver address
#* I check that the other account's TGD balance has gone up
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to say, that this test have not finished steps because we need validator with some Engagement points

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E tests E2E tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement [e2e-c02]withdrawMyRewardsToAnother.feature
2 participants