Skip to content
This repository has been archived by the owner on Feb 19, 2024. It is now read-only.

fix repo key updates on each puppet run #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hensema
Copy link

@hensema hensema commented Sep 5, 2017

This PR fixes the repo key updates on each puppet run in issue #20

It properly uses the notify/refreshonly parameters on the resources. Now the key is only updated when the repository file is updated.

Copy link

@Yggdrasil Yggdrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I ran into the same issue and your fix seems correct.

There are some formatting problems with the PR because you're using leading tabs instead of the spaces the existing code uses. I would suggest changing that, then you have my vote for getting it merged.

@hensema
Copy link
Author

hensema commented Oct 5, 2017

Please don't reject patches on formatting issues, it's offensive to your contributers (me). I don't know the requirements on each and every project.

I suggest embracing your contributors and reformatting the patch after accepting it. And leave them a note requesting proper formatting as per project requirements the next time.

@Yggdrasil
Copy link

@hensema Sorry, I'm not the maintainer. I probably should've made clearer that I'm just another contributer with some feedback in the hopes of getting this problem fixed. In my experience the better a pull request the more quickly it is merged since OSS maintainers are frequently busy people. Hence my suggestion, which is not a requirement or rejection at all. Again, thanks for your effort.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants