Use puppetlabs-apt & require_packages() #18
Conversation
Rework puppet code to support new GPG endpoints, version bump
Fixes lint fail when using examples, use single quotes for non variable strings
Fix quotes in names
* Also changes elsif blocks for a case statement
Puppet-lint rule fixed: class included by relative name on line 31
|
I would love for this to go in, as I'm currently experiencing Package collision problems with this module. |
* Also adds coverage class
…defined_type Refactor gem repo into defined type
Changes to use top scoped class include
|
@mcasper sure thing; give me a few minutes/hours/etc :) |
|
@mcasper I think that's right - although might be worth checking that I haven't wrecked anything you've done. |
|
Looks good to me! :) |
| package { 'apt-transport-https': | ||
| ensure => latest, | ||
| } | ||
| ensure_packages('apt-transport-https') |
There was a problem hiding this comment.
Took keep the same functionality, should it not be "{ ensure => 'latest' }"
This should also be converted to ensure_packages:
'OEL': {
package { 'pygpgme':
ensure => latest,
}
| path => "/etc/apt/sources.list.d/${normalized_name}.list", | ||
| mode => '0644', | ||
| content => template('packagecloud/apt.erb'), | ||
| } elsif $type == 'deb' { |
There was a problem hiding this comment.
This line should be changed back to 'deb': { because we're in case statement here, not an if/else block. :)
| $repo_url = "${base_url}/${repo_name}/${osname}" | ||
| $distribution = $::lsbdistcodename | ||
|
|
||
| file { $normalized_name: |
There was a problem hiding this comment.
The require => File[$normalized_name] line should now also be removed from Exec["apt_key_add_${normalized_name}"] a bit further down, since File[$normalized_name] has now been replaced with an apt::source resource.
|
Hi, any news on when this will be merged? |
| repos => "${component}", | ||
| key => { | ||
| 'id' => '418A7F2FB0E1E6E7EABF6FE8C2E73424D59097AB', | ||
| 'server' => 'pgp.mit.edu' |
There was a problem hiding this comment.
Unfortunately, we can't use pgp.mit.edu. We used to use this in the past, but it goes down very, very often and it breaks most of our user's CI/CD/deploys when that happens.
Refactored:
ensure_packages( ... )in place ofpackage{ ... }type to avoid collisions with other modules usingapt-transport-https