including kab locale #111
Open
including kab locale #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ftyers Would this be something you can take a look at? |
ftyers
suggested changes
Sep 15, 2022
There was a problem hiding this comment.
In general looks good, but it would be nice when replacements are done to include the Unicode codepoints in a comment so it's clear what is being done. (e.g. when two chars look identical). I have some of this stuff in the validation script for covo, e.g. in the kab/validate.tsv file.
|
|
||
| allowed.extend(list(majuscule)) | ||
|
|
||
| replacer = { |
There was a problem hiding this comment.
maybe give the unicode code points in a comment here, e.g.
"Ğ": "Ǧ", # 011E → 01E6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.