Change ticks --> apostrophes #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 4, 2019 15:52
There are a lot of tick marks that occur in English Common Voice that should be apostrophes This is part of a larger problem which involves quotation marks / double quotes
This is also an issue WRT hyphens... should hyphens and dashes be collapsed?
there are 160 utterances with C++ spoken in common voice english, and this user is in the `test.csv` file after `test.tsv` is passed through `import_cv2.py`, and I verified that it is spoken this way
I listened to this myself
kdavis-mozilla
suggested changes
Oct 6, 2019
| sentence = sentence.replace("C++", "C plus plus") | ||
| ## collapse all apostrophe-like marks | ||
| ## e.g. common_voice_en_18441344.mp3 ‘I’m not a serpent!’ --> 'I'm not a serpent!' | ||
| sentence = sentence.replace("’","'") # right-ticks --> apostrophes |
There was a problem hiding this comment.
Is this always the right thing to do? For instance see here.
| ## collapse all apostrophe-like marks | ||
| ## e.g. common_voice_en_18441344.mp3 ‘I’m not a serpent!’ --> 'I'm not a serpent!' | ||
| sentence = sentence.replace("’","'") # right-ticks --> apostrophes | ||
| sentence = sentence.replace("‘","'") # left-ticks --> apostrophes |
There was a problem hiding this comment.
I'd guess I'd pose a similar question here.
| sentence = sentence.replace("‘","'") # left-ticks --> apostrophes | ||
| ## Change em-dash to dash | ||
| ## e.g. common_voice_en_18607891.mp3 Nelly, come here — is it morning? --> Nelly, come here – is it morning? | ||
| sentence = sentence.replace("—","–") |
There was a problem hiding this comment.
Also here; em-dash is used in cases where dash is not used and vice versa. For instance see here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of tick marks that occur in English Common Voice that should be apostrophes
This is part of a larger problem which involves quotation marks / double quotes