Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiple possible file names #546

Merged
merged 12 commits into from
Jul 25, 2024
Merged

support multiple possible file names #546

merged 12 commits into from
Jul 25, 2024

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Jul 25, 2024

working version of #542

generically allows any list of file names per type by making multiple upload requests

  • the failed request comes back and temporarily shows "not found" on the button
    • we can potentially wait for both/all to come back.
    • or add new urls param to the athena upload endpoint, but that requires more changes to request file types instead of file names

We'll take the first naive approach to get this shipped ASAP, then properly fix once we drop file extensions altogether (hopefully soon after).

We instead use one doUpload call with multiple file paths and check the failed list that returns. If not all file paths for a segment fail, no fail.

Copy link

github-actions bot commented Jul 25, 2024

Welcome to connect! Make sure to:

  • read the contributing guidelines
  • mark your PR as a draft until it's ready to review
  • post the preview on Discord; feedback from users will speedup the PR review

deployed preview: https://546.connect-d5y.pages.dev

@sshane sshane merged commit 79880f1 into master Jul 25, 2024
3 checks passed
@sshane sshane deleted the zstd-v2 branch July 25, 2024 06:04
@sshane
Copy link
Contributor Author

sshane commented Jul 25, 2024

You can switch back and forth between athenad versions and it all just works:

image

Any cached uploads will fail though, which is expected as at that point you're requesting a zst/bz2 file to be uploaded to its counterpart url which isn't what we want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant