-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add promises to transactions and calls #1450
Open
alessey
wants to merge
4
commits into
main
Choose a base branch
from
alessey/transaction-promises
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alessey
force-pushed
the
alessey/transaction-promises
branch
from
October 18, 2024 01:26
bd71b2f
to
9c3253b
Compare
fakepixels
approved these changes
Oct 18, 2024
alessey
force-pushed
the
alessey/transaction-promises
branch
from
October 18, 2024 02:27
9c3253b
to
7e8b4ef
Compare
alessey
force-pushed
the
alessey/transaction-promises
branch
from
October 18, 2024 02:30
7e8b4ef
to
63af146
Compare
alessey
commented
Oct 18, 2024
@@ -18,11 +18,12 @@ export function Transaction({ | |||
}: TransactionReact) { | |||
const isMounted = useIsMounted(); | |||
const componentTheme = useTheme(); | |||
const { chain } = useOnchainKit(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fixes the hooks order console error
cpcramer
approved these changes
Oct 18, 2024
0xAlec
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Notes to reviewers
How has it been tested?