Support Rosetta Currency to be passed as argument #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeekArthur
requested changes
Jan 22, 2024
| // TraceOps returns all *RosettaTypes.Operation for a given | ||
| // array of flattened traces. | ||
| // nolint:gocognit | ||
| func TraceOps( | ||
| calls []*evmClient.FlatCall, | ||
| startIndex int, | ||
| args ...interface{}, |
There was a problem hiding this comment.
this function argument change can potentially break all upstream Rosetta (e.g. Base, Arbitrum, BSC). regression tests for different chains are needed for this change
| @@ -130,7 +130,9 @@ func TransferOps(tx *evmClient.LoadedTransaction, startIndex int) []*RosettaType | |||
| return ops | |||
| } | |||
|
|
|||
| func FeeOps(tx *evmClient.LoadedTransaction) []*RosettaTypes.Operation { | |||
| func FeeOps(tx *evmClient.LoadedTransaction, args ...interface{}) []*RosettaTypes.Operation { | |||
There was a problem hiding this comment.
this function argument change can potentially break all upstream Rosetta (e.g. Base, Arbitrum, BSC). regression tests for different chains are needed for this change
|
@sajjad-zaidi-cb can you do some research on the solutions where achieving currency flexibility but still ensure backward compatibility? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Motivation
Currently currency is defaulting to Eth for fee/trace ops.
Solution
This PR is allows the ability to pass currency or it defaults to sdk currency.
client.test is covering this
Open questions