Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use baseURI instead of base_uri #9296

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

refactor: use baseURI instead of base_uri #9296

wants to merge 2 commits into from
+44 −55

Conversation

paulbalandan
Copy link
Member

Description
Fixes #9265
Replaces and closes #9280

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan
Copy link
Member Author

The test is useless because (1) in PHP, arrays with duplicate keys always retains the last key, and (2) CURLRequest::parseOptions() only checks for baseURI key not base_uri.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: base_uri or baseURI in curlrequest?
2 participants
@paulbalandan @michalsn