Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use Superglobals in setting 'REQUEST_METHOD' in `FeatureT… #9294

Merged
merged 1 commit into from
Nov 29, 2024
Merged

refactor: use Superglobals in setting 'REQUEST_METHOD' in `FeatureT… #9294

merged 1 commit into from
Nov 29, 2024
+5 −23

Conversation

paulbalandan
Copy link
Member

…estTrait`

Description
Fixes related errors in latest release of PHPStan

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Nov 29, 2024
@paulbalandan
Copy link
Member Author

Thank you, @samsonasik for the review

@paulbalandan paulbalandan merged commit 700ba29 into codeigniter4:develop Nov 29, 2024
41 checks passed
@paulbalandan paulbalandan deleted the phpstan-1.12 branch November 29, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbalandan @samsonasik