Merge pull request #9279 from ping-yee/9043_pg_ping()

fix: `Postgre\Connection::reconnect()` `TypeError` in `pg_ping()`
codeigniter4 · Nov 30, 2024 · 17fa4d0 · 17fa4d0
2 parents d81f4c5 + 0c9799f
commit 17fa4d0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/system/Database/Postgre/Connection.php b/system/Database/Postgre/Connection.php
@@ -149,8 +149,9 @@ private function convertDSN()
      */
     public function reconnect()
     {
-        if (pg_ping($this->connID) === false) {
-            $this->connID = false;
+        if ($this->connID === false || pg_ping($this->connID) === false) {
+            $this->close();
+            $this->initialize();
         }
     }
 

diff --git a/user_guide_src/source/changelogs/v4.5.6.rst b/user_guide_src/source/changelogs/v4.5.6.rst
@@ -41,6 +41,7 @@ Bugs Fixed
 
 - **Validation:** Fixed a bug where complex language strings were not properly handled.
 - **CURLRequest:** Added support for handling proxy responses using HTTP versions other than 1.1.
+- **Database:** Fixed a bug that caused ``Postgre\Connection::reconnect()`` method to throw an error when the connection had not yet been established.
 
 See the repo's
 `CHANGELOG.md <https://github.com/codeigniter4/CodeIgniter4/blob/develop/CHANGELOG.md>`_