Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add new module: seqkit/rmdup #24

Merged
merged 5 commits into from
Nov 13, 2023
Merged

✨ add new module: seqkit/rmdup #24

merged 5 commits into from
Nov 13, 2023

Conversation

bunop
Copy link
Member

@bunop bunop commented Nov 11, 2023

PR checklist

Add seqkit/rmdup module

Closes #23

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@bunop bunop added the enhancement New feature or request label Nov 11, 2023
solve problem with docker tests and increment resource usage for seqkit/rmdup
@bunop bunop merged commit f96703a into master Nov 13, 2023
8 checks passed
@bunop bunop deleted the issue-23 branch December 15, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new module: seqkit/rmdup
1 participant