Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ track constants and status in database #39

Merged
merged 5 commits into from
Nov 11, 2021
Merged

✨ track constants and status in database #39

merged 5 commits into from
Nov 11, 2021

Conversation

bunop
Copy link
Member

@bunop bunop commented Nov 11, 2021

Description

With this PR we track database constants in a collection and we add background/foreground types to the samples

Related Issue

closes #11

Motivation and Context

This change is required to track information that can useful in API

How Has This Been Tested?

code as been tested with CI and by recreating the database

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change which improve code itself)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bunop bunop added the enhancement New feature or request label Nov 11, 2021
@bunop bunop added this to the SMARTER database v1.0.0 milestone Nov 11, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 91.707% when pulling a4a1260 on issue-11 into 62096f8 on devel.

@bunop bunop merged commit 0afa0f1 into devel Nov 11, 2021
@bunop bunop deleted the issue-11 branch November 11, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants