Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bundle): add param and cred validation #191

Merged
merged 2 commits into from
Mar 9, 2020
Merged

feat(bundle): add param and cred validation #191

merged 2 commits into from
Mar 9, 2020

Conversation

vdice
Copy link
Member

@vdice vdice commented Mar 3, 2020

  • adds Parameter and Credential validation, per spec
  • validates both when validating a Bundle
  • moved a few other validation functions closer to the structs they validate

@vdice vdice force-pushed the feat/param-cred-validation branch from 535e363 to 6cb147d Compare March 3, 2020 19:14
silvin-lubecki
silvin-lubecki reviewed Mar 4, 2020
View reviewed changes
bundle/bundle.go Outdated Show resolved Hide resolved
@vdice vdice force-pushed the feat/param-cred-validation branch from 6cb147d to b1defa8 Compare March 4, 2020 20:38
@vdice vdice mentioned this pull request Mar 4, 2020
Open
@vdice
Copy link
Member Author

vdice commented Mar 4, 2020

Updated/rebased; PTAL when convenient @silvin-lubecki .

carolynvs
carolynvs approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carolynvs carolynvs merged commit eb7dfe1 into cnabio:master Mar 9, 2020
@vdice vdice deleted the feat/param-cred-validation branch March 9, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvin-lubecki silvin-lubecki silvin-lubecki left review comments

@radu-matei radu-matei radu-matei approved these changes

@carolynvs carolynvs carolynvs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vdice @carolynvs @radu-matei @silvin-lubecki