Skip to content
This repository has been archived by the owner on Oct 19, 2021. It is now read-only.

Output more location data in lint errors #645

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mf-corey
Copy link

I've been working on an automated lint error fixer. Basically it takes the output from Coffeelint and programmatically fixes the errors when possible (e.g. for errors like no_unnecessary_fat_arrows where the intent is obvious and the fix is simple).

This change enables the automated fixer, which relies on this fine-grain error location data. I also add 'expected' and 'actual' indentation information, which is useful in fixing indentation errors.

I had to add location manually to each AST rule, since the rule itself is responsible for recursing into the AST. On the other hand, we can inject location data for all token based linters in the lexical_linter.coffee file.

I could create a separate pull request for my fixer script, which currently supports fixes for the following error types:

  • indentation
  • no_trailing_whitespace
  • no_trailing_semicolons
  • no_unnecessary_double_quotes
  • space_operators
  • spacing_after_comma
  • colon_assignment_spacing
  • no_unnecessary_fat_arrows
  • arrow_spacing

@UziTech
Copy link

UziTech commented Jan 14, 2020

@mf-corey Could you create a PR in https://github.com/coffeelint/coffeelint that is where further development will happen.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants