This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
Add missing_parseint_radix rule #487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ditto. Any chance this could get reviewed or merged? |
|
Further development on coffeelint will be on coffeelint/coffeelint and will be released as @coffeelint/cli. This PR will be tracked at coffeelint/coffeelint#17 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our QA team found a bug in IE8 caused by a
parseIntwithout the radix argument, which unfortunately fell through our code review. It would be great to have a coffeelint rule for this.In JSHint, there's no explicit rule for a missing radix argument, but there's a ES3 flag. It seems to me that most of the ES3 errors are already mitigated by the CoffeeScript transpiler (extra commas, get/set, reserved keywords, etc). That's why I think an explicit
missing_parseint_radixrule seems reasonable, instead of a broader "ES3" rule.I set the default level to
warn. I personally think it makes sense, and it's recommended in the MDN developers reference to always specify the radix argument. I would be ok withignoreas well, if you think a warning is too invasive.