Add namespace explicitly #461
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CiraciNicolo
requested review from
itay-grudev,
fcanovai,
gbartolini,
leonardoce,
mnencia,
phisco and
sxd
as code owners
CiraciNicolo
force-pushed
the
fix(namespace)
branch
from
cc154e3 to
61d697c
Compare
itay-grudev
requested changes
Dec 7, 2024
itay-grudev
added
chart( cluster )
itay-grudev
reviewed
Dec 7, 2024
There was a problem hiding this comment.
Could you also look at the test failures? Example:
Error: template: cluster/templates/pooler.yaml:7:16: executing "cluster/templates/pooler.yaml" at <include "cluster.namespace" .>: error calling include: template: cluster/templates/_helpers.tpl:5:16: executing "cluster.namespace" at <.Values.namespaceOverride>: nil pointer evaluating interface {}.namespaceOverride
a4bb41b to
ed5f083
Compare
CiraciNicolo
force-pushed
the
fix(namespace)
branch
from
22e5b5f to
b7dc6ab
Compare
Signed-off-by: Nicolò Ciraci <[email protected]>
…#453) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Nicolò Ciraci <[email protected]>
Signed-off-by: Nicolò Ciraci <[email protected]>
Signed-off-by: Nicolò Ciraci <[email protected]>
CiraciNicolo
force-pushed
the
fix(namespace)
branch
from
b7dc6ab to
330122c
Compare
Signed-off-by: Nicolò Ciraci <[email protected]>
CiraciNicolo
force-pushed
the
fix(namespace)
branch
from
330122c to
2296230
Compare
|
I don't understand the DCO failure, the commits are signed. |
|
One of your commits isn't, but you can manually set it to pass from here. |
|
No, all my commits are signed. If you notice the error is quite strange:
Am I missing something obvious? |
|
No matter. This is good enough for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rationale behind this PR is that there are cases where it becomes quite complicated to deploy the application unless the namespace is explicitly provided — for example, when managing the application using a GitOps approach.