Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParadeDB UID GID #393

Closed
wants to merge 10 commits into from

Using the default UID/GID 999 from the postgres docker image

b035e5b
Select commit
Loading
Failed to load commit list.
Closed

ParadeDB UID GID #393

Using the default UID/GID 999 from the postgres docker image
b035e5b
Select commit
Loading
Failed to load commit list.
DCO / DCO required action Sep 18, 2024 in 1s

DCO

There are 8 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <[email protected]> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.

Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~10 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin paradedb_uid_gid

Summary

Commit sha: 9ba0825, Author: Itay Grudev, Committer: GitHub; Expected "Itay Grudev [email protected]", but got "Philippe Noël [email protected]".
Commit sha: 0623a8b, Author: Itay Grudev, Committer: GitHub; The sign-off is missing.
Commit sha: b035e5b, Author: Itay Grudev, Committer: Itay Grudev; The sign-off is missing.
Commit sha: c9e5f3e, Author: Philippe Noël, Committer: GitHub; The sign-off is missing.
Commit sha: a9f340d, Author: Philippe Noël, Committer: GitHub; The sign-off is missing.
Commit sha: 59b9b50, Author: Philippe Noël, Committer: Philippe Noël; The sign-off is missing.
Commit sha: 690aab4, Author: Philippe Noël, Committer: GitHub; The sign-off is missing.
Commit sha: da440ca, Author: Philippe Noël, Committer: Philippe Noël; The sign-off is missing.

View more details on DCO