net:poll: Add log line when the reactor wakes up without commands

This commit removes the debug assert since it occurs a few times. Therefore, the debug assert is replaced with a warning log line, allowing us to track the frequency of this occurrence. Signed-off-by: Vincenzo Palazzo <[email protected]>
cloudhead · Dec 31, 2023 · 4394ac2 · 4394ac2
1 parent 9ea71ed
commit 4394ac2
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/net/poll/src/reactor.rs b/net/poll/src/reactor.rs
@@ -244,9 +244,12 @@ impl<Id: PeerId> nakamoto_net::Reactor<Id> for Reactor<net::TcpStream, Id> {
                                 }
                                 popol::Waker::reset(ev.source).ok();
 
-                                // Nb. This assert has triggered once, but I wasn't available
-                                // to reproduce it.
-                                debug_assert!(!commands.is_empty());
+                                // Nb. This should not happen, but it has been reported
+                                // a few times. So we try to log a warning message and
+                                // see how often this occurs.
+                                if commands.is_empty() {
+                                    log::warn!(target: "poll", "waken up by waker received without commands");
+                                }
 
                                 for cmd in commands.try_iter() {
                                     service.command_received(cmd);