[ui-storagebrowser] adds file preview and save for files #3869
+301
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornalm
reviewed
Oct 17, 2024
| }; | ||
|
|
||
| const handleSave = () => | ||
| save({ |
There was a problem hiding this comment.
Now if we are establishing a pattern it is reasonable be a bit more picky than usual :-)
I thought about this during the other PR review. Doesn't it make more sense to handle the save success and failure here instead of at the top where we get the save function from the hook? That way the logic is grouped together.
save({...}).then(()=>{do stuff}).catch(...)
or if the error handling is done by the hook like in this example
const success = await save({...});
if (success ) {...}
|
|
||
| const StorageFilePage = ({ fileData }: { fileData: PathAndFileData }): JSX.Element => { | ||
| const { t } = i18nReact.useTranslation(); | ||
| const [isEditing, setIsEditing] = React.useState(false); | ||
| const [fileContent, setFileContent] = React.useState(fileData.view?.contents); | ||
| const fileMetaData = useMemo(() => getFileMetaData(t, fileData), [t, fileData]); | ||
|
|
||
| const { loading: isSaving, save } = useSaveData(SAVE_FILE_API_URL, { | ||
| onSuccess: () => { | ||
| setIsEditing(false); |
There was a problem hiding this comment.
I would disable editing as soon as the save button was clicked, not when successful. If save failed I would enable the editing again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?