fix by_id not free when use_host_ino=true #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyfjeff
requested review from
bergwolf,
imeoer,
liubogithub and
eryugey
as code owners
|
New version of rust clippy bugs |
|
Waiting for this #187 pr to be merged will solve the CI problem. |
eryugey
reviewed
Mar 26, 2024
src/passthrough/mod.rs
Outdated
| @@ -777,7 +777,7 @@ impl<S: BitmapSlice + Send + Sync> PassthroughFs<S> { | |||
| // We just removed the last refcount for this inode. | |||
| // The allocated inode number should be kept in the map when use_host_ino | |||
| // is false or inode is bigger than MAX_HOST_INO. | |||
There was a problem hiding this comment.
Update the comment as well? "inode" should refer to host inode or real inode?
eryugey
approved these changes
Mar 26, 2024
When use_host_ino mode is turned on, we only need to save the by_id relationship if the host inode of the file is larger than MAX_HOST_INO, and don't remove it. however, the previous code used a virtual inode combining the host inode, dev, mnt, and other parts of the file, and this inode is a 56bit inode, which is always larger than MAX_HOST_INO, and so it resulted in the by_id relationship not being cleaned up. Signed-off-by: zyfjeff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When use_host_ino mode is turned on, we only need to save the by_id relationship if the host inode of the file is larger than MAX_HOST_INO, and don't remove it. however, the previous code used a virtual inode combining the host inode, dev, mnt, and other parts of the file, and this inode is a 56bit inode, which is always larger than MAX_HOST_INO, and so it resulted in the by_id relationship not being cleaned up.