Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow selecting multiple metrics on compare page #133

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Commits on Oct 18, 2024

  1. Add new Crucible backend service

    This encapsulates substantial logic to encapsulate interpretation of the
    Crucible Common Data Model OpenSearch schema for the use of CPT dashboard API
    components. By itself, it does nothing.
    dbutenhof committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    6717f4d View commit details
    Browse the repository at this point in the history
  2. Add an ilab API module for InstructLab

    This builds on the `crucible_svc` layer in cloud-bulldozer#122 to add a backend API.
    dbutenhof committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    55f9c2b View commit details
    Browse the repository at this point in the history
  3. Add an ilab UI tab

    This relies on the ilab API in cloud-bulldozer#123, which in turn builds on the crucible
    service in cloud-bulldozer#122.
    MVarshini authored and dbutenhof committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    176ddee View commit details
    Browse the repository at this point in the history
  4. Support graphing multiple run comparisons

    When graphing metrics from two runs, the timestamps rarely align; so we add a
    `relative` option to convert the absolute metric timestamps into relative
    delta seconds from each run's start.
    dbutenhof committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    7215bb2 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Multi-run comparison UI

    This adds the basic UI to support comparison of the metrics of two InstructLab
    runs. This compares only the primary metrics of the two runs, in a relative
    timeline graph.
    
    This is backed by cloud-bulldozer#125, which is backed by cloud-bulldozer#124, which is backed by cloud-bulldozer#123,
    which is backed by cloud-bulldozer#122. These represent a series of steps towards a complete
    InstructLab UI and API, and will be reviewed and merged from cloud-bulldozer#122 forward.
    MVarshini authored and dbutenhof committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    1fb02a0 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Crucible statistics comparison

    This PR is primarily CPT dashboard backend API (and Crucible service) changes
    to support pulling and displaying multiple Crucible metric statistics. Only
    minor UI changes are included to support API changes. The remaining UI changes
    to pull and display statistics will be pushed separately.
    dbutenhof committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    bea1372 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Display statistical summaries

    Add statistics charts for selected metric in row expansion and comparison
    views.
    dbutenhof committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    1245407 View commit details
    Browse the repository at this point in the history
  2. Add metadata flyover on comparison page

    Extract the "Metadata" into a separate component, which allows it to be reused
    as an info flyover on the comparison page to help in identifying target runs
    to be compared.
    dbutenhof committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    f2c28fd View commit details
    Browse the repository at this point in the history
  3. Support selection of multiple metrics

    Modify the metrics pulldown to allow multiple selection. The statistical
    summary chart and graph will show all selected metrics in addition to the
    inherent benchmark primary benchmark (for the primary period).
    dbutenhof committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    ea19d5a View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Add metrics pulldown to compare view

    Support selection of multiple metrics using the pulldown in the comparison
    page. The update occurs when the pulldown closes.
    
    To simplify the management of "available metrics" across multiple selected
    runs, which might have entirely different metrics, the reducer no longer
    tries to store separate metric selection lists for each run. This also means
    that the "default" metrics selection remains when adding another comparison
    run, or expanding another row.
    dbutenhof committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    ac58188 View commit details
    Browse the repository at this point in the history