Support renaming with :as in import-vars

README.md

@@ -27,7 +27,7 @@ The former approach places an onus on the creator of the library; the various or
 ```clojure
 (import-vars
   [clojure.walk
-    prewalk
+    [prewalk :as walk-pre]
     postwalk]
   [clojure.data
     diff])

src/potemkin/namespaces.clj

@@ -78,26 +78,33 @@
   "Imports a list of vars from other namespaces."
   [& syms]
   (let [unravel (fn unravel [x]
-                  (if (sequential? x)
+                  (cond
+                    (and (vector? x) (#{:as} (second x)))
+                    [(with-meta (first x) {:name (nth x 2)})]
+
+                    (sequential? x)
                     (->> x
                          rest
                          (mapcat unravel)
                          (map
-                          #(symbol
-                            (str (first x)
-                                 (when-let [n (namespace %)]
-                                   (str "." n)))
-                            (name %))))
-                    [x]))
+                          #(with-meta (symbol
+                                       (str (first x)
+                                            (when-let [n (namespace %)]
+                                              (str "." n)))
+                                       (name %))
+                             (meta %))))
+
+                    :else [x]))
         syms (mapcat unravel syms)]
     `(do
        ~@(map
           (fn [sym]
             (let [vr (resolve sym)
-                  m (meta vr)]
+                  m (meta vr)
+                  ?name (-> sym meta :name)]
               (cond
-               (nil? vr) `(throw (ex-info (format "`%s` does not exist" '~sym) {}))
-               (:macro m) `(import-macro ~sym)
-               (:arglists m) `(import-fn ~sym)
-               :else `(import-def ~sym))))
+                (nil? vr) `(throw (ex-info (format "`%s` does not exist" '~sym) {}))
+                (:macro m) `(import-macro ~sym ~?name)
+                (:arglists m) `(import-fn ~sym ~?name)
+                :else `(import-def ~sym ~?name))))
           syms))))

test/potemkin/namespaces_test.clj

@@ -13,6 +13,10 @@
 (import-fn i/protocol-function)
 (import-fn i/inlined-fn)
 (import-def i/some-value)
+(import-vars [potemkin.imports-test
+              [multi-arity-macro :as renamed-multi-arity-macro]
+              [multi-arity-fn :as renamed-multi-arity-fn]
+              [some-value :as renamed-some-value]])
 
 
 (defn drop-lines [n s]
@@ -50,3 +54,10 @@
     (is false "`import-vars` should have thrown an exception")
   (catch Exception ex
     (is "`clojure.set/onion-misspelled` does not exist" (.getMessage ex)))))
+
+(deftest import-vars-allows-renaming
+  (is (= 1 renamed-some-value))
+  (is (out= (source i/multi-arity-fn) (source renamed-multi-arity-fn)))
+  (is (rest-out= (doc i/multi-arity-fn) (doc renamed-multi-arity-fn)))
+  (is (out= (source i/multi-arity-macro) (source renamed-multi-arity-macro)))
+  (is (rest-out= (doc i/multi-arity-macro) (doc renamed-multi-arity-macro))))