Manage JVM vs. CLJS dependencies better #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use Java Time in README examples * removes clj-time as a dependency * moves js-joda to a :cljs-test only dependency * kongeor/cljs-test-runner is behind olical/cljs-test-runner so switch to the latter * update build-tools * update GH workflow dependencies * ignore Calva REPL file * remove unnecessary cljc_test file (both clj and cljs test runners file the tests just fine) * use clojure.math in cljs and clj * fix the bad cljs-only test splice Signed-off-by: Sean Corfield <[email protected]>
|
The |
Signed-off-by: Sean Corfield <[email protected]>
kongeor
approved these changes
Nov 12, 2024
| user> (require '[clj-time.core :as t]) | ||
| nil | ||
| user> (import '(java.time LocalDateTime) '(java.time.temporal ChronoUnit)) | ||
| java.time.temporal.ChronoUnit |
There was a problem hiding this comment.
Both of these imports are used so I'm not sure why you think this is redundant?
hlship
approved these changes
Nov 12, 2024
hlship
changed the title
|
Thanks for this; sorting out the JVM vs. CLJS stuff was something outside my wheelhouse as I don't do much with CLJS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42 by:
Signed-off-by: Sean Corfield [email protected]