Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added standard error of the mean to statistics_of_labelled_pixels #267

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

thawn
Copy link
Collaborator

@thawn thawn commented Feb 27, 2023

I think this should calculate the SEM, but please double check. If I read the code correctly, this automagically adds SEM also to statistics_of_background_and_labelled_pixels

@thawn
Copy link
Collaborator Author

thawn commented Mar 7, 2023

@haesleinhuepf I am just working on the tests and a question came up:
should the statistics also appear in the output of push_regionprops()?
if yes, should they be inserted where they belong semantically in pos 15 below props['standard_deviation_intensity'], or where they are backwards compatible at the end (pos 36)?

furthermore, I feel confident, that I can add the code in case the input is a dict. in the case that the input is a RegionProperties object, I am less confident... (and also don't know if the standard error would appear in that case)

@thawn
Copy link
Collaborator Author

thawn commented Mar 8, 2023

@haesleinhuepf I now added a simple test for the standard error. Would you like to also add the standard error to push_regionprops (see my question above?)

@haesleinhuepf
Copy link
Member

haesleinhuepf commented Mar 11, 2023

Would you like to also add the standard error to push_regionprops (see my question above?)

Yes, it seems this makes sense! Please make the backwards-compatible change as you suggested. Thank you!

@thawn
Copy link
Collaborator Author

thawn commented Mar 20, 2023

@haesleinhuepf I just added the SEM to push_regionprops. Also adapted the tests accordingly.

@thawn thawn marked this pull request as ready for review April 1, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants