Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to output iframe.php file to stdout #31326

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmcclelland
Copy link
Contributor

Overview

Provide an API action for the iframe extension that outputs the iframe.php code to standard out.

Before

The only available API action (Iframe.installScript) is to save the iframe.php to the expected location in the web root.

However, if you are running CiviCRM with locked down permission that prevents the user that execute the cv command from writing to any source directories, the Iframe.installScript action will fail. That makes it hard to automate this process.

After

With a new API action, outputScript, we can run a cv command the sends the contents of the script to standard out, allowing the user that calls the script to save it to the right spot and/or use sudo or any other method to ensure it get's put in the right place.

Comments

We still get "[]" output at the end of the cv call. I'm not sure how to suppress that, but it's not that hard to handle.

Copy link

civibot bot commented Oct 18, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant