Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a valid project by default #888

Merged
merged 1 commit into from
May 1, 2019
Merged

Conversation

stevendanna
Copy link
Contributor

@stevendanna stevendanna commented May 1, 2019

Omnibus was previously generating an invalid project by default
because it:

  • Didn't include a version-manifest software definition
  • Didn't include the "preparation" software definition
  • Had an invalid Gemfile

This fixes those issues, getting us a bit closer to the Getting
Starting directions working out of the box for people.

Fixes #887
Partially addresses #841

Signed-off-by: Steven Danna [email protected]

Maintainers

Please ensure that you check for:

  • If this change impacts git cache validity, it bumps the git cache
    serial number
  • If this change impacts compatibility with omnibus-software, the
    corresponding change is reviewed and there is a release plan
  • If this change impacts compatibility with the omnibus cookbook, the
    corresponding change is reviewed and there is a release plan

Omnibus was previously generating an invalid project by default
because it:

- Didn't include a version-manifest software definition
- Didn't include the "preparation" software definition
- Had an invalid Gemfile

This fixes those issues, getting us a bit closer to the Getting
Starting directions working out of the box for people.

Fixes #887
Partially addresses #841

Signed-off-by: Steven Danna <[email protected]>
@tas50 tas50 merged commit 1f3a38f into master May 1, 2019
@tas50
Copy link
Contributor

tas50 commented May 1, 2019

Thanks @stevendanna

@chef-ci chef-ci deleted the ssd/a-few-generator-fixes branch May 1, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

omnibus new creates invalid Gemfile
3 participants