Optimize our requires

Avoid requiring things that are already defined. Rubygems is very slow at traversing the filesystem.

Signed-off-by: Tim Smith <[email protected]>

Rakefile

@@ -39,7 +39,7 @@ rescue LoadError
 end
 
 begin
-  require "yard"
+  require "yard" unless defined?(YARD)
   YARD::Rake::YardocTask.new(:docs)
 rescue LoadError
   puts "yard is not available. bundle install first to make sure all dependencies are installed."

lib/mixlib/log/formatter.rb

@@ -16,7 +16,7 @@
 # limitations under the License.
 
 require "logger"
-require "time"
+require "time" unless defined?(Time)
 
 module Mixlib
   module Log

spec/mixlib/log/child_spec.rb

@@ -15,8 +15,8 @@
 # limitations under the License.
 #
 
-require "tempfile"
-require "stringio"
+require "tempfile" unless defined?(Tempfile)
+require "stringio" unless defined?(StringIO)
 require "spec_helper"
 
 RSpec.describe Mixlib::Log::Child do

spec/mixlib/log/formatter_spec.rb

@@ -16,7 +16,7 @@
 # limitations under the License.
 #
 
-require "time"
+require "time" unless defined?(Time)
 require File.expand_path(File.join(File.dirname(__FILE__), "..", "..", "spec_helper"))
 
 RSpec.describe Mixlib::Log::Formatter do

spec/mixlib/log_spec.rb

@@ -17,8 +17,8 @@
 # limitations under the License.
 #
 
-require "tempfile"
-require "stringio"
+require "tempfile" unless defined?(Tempfile)
+require "stringio" unless defined?(StringIO)
 require "spec_helper"
 
 class LoggerLike