Adds definitions for projects and maintainership of projects #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tas50
reviewed
Dec 12, 2018
definitions.md
Outdated
|
|
||
| A Product consists of one or more Projects. | ||
|
|
||
| ### Project |
There was a problem hiding this comment.
This one should go at the top since it's the basis of everything
tas50
reviewed
Dec 12, 2018
definitions.md
Outdated
|
|
||
| A Project is one GitHub repo that contains code. | ||
|
|
||
| ### Maintainers |
There was a problem hiding this comment.
We should come up with a full definition of what a maintainer is.
There was a problem hiding this comment.
Perhaps just a modification of the definition below:
Those responsible for merging pull requests, triaging issues, and general project maintenance.
Signed-off-by: Nell Shamrell <[email protected]>
|
@tas50 just pushed fixes :) |
|
Got approval in zoom meeting, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14 and partially resolves #15