Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Do not merge]Go Component - FetchAndPersist #186

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

[Do not merge]Go Component - FetchAndPersist #186

wants to merge 46 commits into from

Conversation

ashiqueps
Copy link

Description

This PR implements the FetchAndPersist method of the ruby component. This will fetch the license key from either the argument or the env or collect the license interactively from the user. Once the key is collected, it will be validated with the licensing server and stored on the local disk for future validations.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

ashiqueps and others added 19 commits July 2, 2024 17:19
@ashiqueps
Go - fetch and persist implementation
4e6fd2c 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
Fixed the issue with license details not showing up on the warning sc…
c4c10d2 
…reens

Signed-off-by: Ashique Saidalavi <[email protected]>
@nikhil2611
added some fixes
44d0ba8 
Signed-off-by: nikhil2611 <[email protected]>
@ashiqueps
Merge branch 'CHEF-2618-go-implementation-chef-licensing' of github.c…
bf4089d 
…om:chef/chef-licensing into CHEF-2618-go-implementation-chef-licensing
@ashiqueps
Updated the typo
30db893 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
Fixed the final error handling
d3ec161 
Signed-off-by: Ashique Saidalavi <[email protected]>
@nikhil2611
added log to print license-key
d7d2911 
Signed-off-by: nikhil2611 <[email protected]>
@ashiqueps
Updated the fmt.println to log.println
de76f9a 
Signed-off-by: Ashique Saidalavi <[email protected]>
@nikhil2611
reverted back the print log
11954b2 
Signed-off-by: nikhil2611 <[email protected]>
@ashiqueps
Fixed the styling issues on the interactions
81a1490 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
Merge branch 'CHEF-2618-go-implementation-chef-licensing' of github.c…
e90df28 
…om:chef/chef-licensing into CHEF-2618-go-implementation-chef-licensing
@ashiqueps
Updated the interactions.yml file
3fb44dc 
Signed-off-by: Ashique Saidalavi <[email protected]>
@nikhil2611
added the logic to accept the --chef-license-key flag and arguments
566699f 
Signed-off-by: nikhil2611 <[email protected]>
@ashiqueps
Added unit tests
5fd1e6d 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
Merge branch 'CHEF-2618-go-implementation-chef-licensing' of github.c…
e441486 
…om:chef/chef-licensing into CHEF-2618-go-implementation-chef-licensing
@ashiqueps
Removed exception causing test case
cdf0e2d 
Signed-off-by: Ashique Saidalavi <[email protected]>
@nikhil2611
added the logic to remove --chef-license-key flag from os.Args
9fbe422 
Signed-off-by: nikhil2611 <[email protected]>
@ashiqueps
Code style changes
f60b5fb 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
Merge branch 'CHEF-2618-go-implementation-chef-licensing' of github.c…
c400c53 
…om:chef/chef-licensing into CHEF-2618-go-implementation-chef-licensing
@ashiqueps ashiqueps mentioned this pull request Jul 10, 2024
Closed
11 tasks
@ashiqueps
Updated the verify pipelines commands
5b49295 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
fixed the typo
172b68b 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
Updated the commands
47b55df 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
Fixed the file_fetcher_test
1294d6b 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
Added logs to debug the test case
954346e 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
Added more logs
7ea3a1d 
Signed-off-by: Ashique Saidalavi <[email protected]>
sanjain-progress
sanjain-progress reviewed Jul 10, 2024
View reviewed changes
components/go/pkg/api/api_client.go Show resolved Hide resolved
components/go/pkg/api/api_client.go Show resolved Hide resolved
components/go/pkg/api/client.go Show resolved Hide resolved
components/go/pkg/api/describe.go Show resolved Hide resolved
components/go/pkg/api/describe.go Show resolved Hide resolved
components/go/pkg/api/feature_entitlement.go Show resolved Hide resolved
components/go/pkg/api/feature_entitlement.go Show resolved Hide resolved
components/go/pkg/api/feature_entitlement.go Show resolved Hide resolved
components/go/pkg/chef_licensing.go Show resolved Hide resolved
components/go/pkg/config/config.go Show resolved Hide resolved
@ashiqueps
Removed the logs added for testing
d009fe9 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
Updated the go version to 1.21.5
d1adf88 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
Added the TTY conditions
eaf073d 
Signed-off-by: Ashique Saidalavi <[email protected]>
nikhil2611 and others added 7 commits July 15, 2024 12:06
@nikhil2611
Hard enforcement fix: Adding the same type of license
94e4b50 
Signed-off-by: nikhil2611 <[email protected]>
@ashiqueps
Updated the spinner
d071c23 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
Merge branch 'CHEF-2618-go-implementation-chef-licensing' of github.c…
6968351 
…om:chef/chef-licensing into CHEF-2618-go-implementation-chef-licensing
@ashiqueps
Merge branch 'main' of github.com:chef/chef-licensing into CHEF-2618-…
6157f7b 
…go-implementation-chef-licensing
@ashiqueps
TTY related fixes
b0db8b0 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
Codereview comments
fd50d79 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
More code review comments addressed
737ab7f 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
Merge branch 'main' of github.com:chef/chef-licensing into CHEF-2618-…
938375b 
…go-implementation-chef-licensing
@ashiqueps
On prem fetch and persist implementation
ab03ac2 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
Logs for debugging the issue on buildkite
482a4a5 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
Removed the failing test case
deb06b9 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
Debugging
b4a9496 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
Debugging
237fc7c 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
debugging again
1acf0a8 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
printing the content for testing
e68815d 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
Fixes for the test cases
e3f6419 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
Hanlded the software not entitled error
eb208c2 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps
Removed the unwanted test file
f37ac5c 
Signed-off-by: Ashique Saidalavi <[email protected]>
@ashiqueps ashiqueps changed the title Go Component - FetchAndPersist [Do not merge]Go Component - FetchAndPersist Sep 4, 2024
@ashiqueps
Copy link
Author

This PR will be merged along with the other PRs to enable the chef-workstation licensing enablement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhil2611 nikhil2611 nikhil2611 approved these changes

@sanjain-progress sanjain-progress sanjain-progress approved these changes

@sanghinitin sanghinitin Awaiting requested review from sanghinitin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashiqueps @nikhil2611 @sanjain-progress