-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: opportunity to set TLS easily by default with ca-certs autogeneration if needed #71
base: main
Are you sure you want to change the base?
Conversation
@YarikRevich Thank you for the PR. Is this in a state where we can test this out? |
@YarikRevich are you still working on this? |
Yes, I'm still working on this. |
@vishnu-narayanan Please, test my PR out |
@YarikRevich Could you please share instructions on how I can test this out? |
@vishnu-narayanan Sure, test is devidid into two parts. Before all use should set "ingress.enabled" to "true" in values.yaml. |
{{/* | ||
Create chart name and version as used by the chart label. | ||
*/}} | ||
{{- define "custom-metrics.chart" -}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
custom-metrics
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, forgot to remove unused parts of configuration
@YarikRevich I am not able to test this.
|
@vishnu-narayanan User should specify DNS name via values.yaml charts/charts/chatwoot/values.yaml Lines 63 to 81 in b5328fb
|
@vishnu-narayanan can we look into the next steps for this PR ? |
@YarikRevich Sorry for the delay here. This got left behind due to other priorites. Will pick this up once the team has enough bandwidth. |
This PR partly solves issue(#69). It addes opportunity to easily set TLS settings using values.yaml file by default.