Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using xpty #151

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: using xpty #151

wants to merge 1 commit into from

Conversation

caarlos0
Copy link
Member

using x/xpty, and using term size as pty size

Signed-off-by: Carlos Alexandro Becker <[email protected]>
@caarlos0 caarlos0 added the enhancement New feature or request label Nov 20, 2024
Copy link
Member

@bashbunni bashbunni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass + tried

  • -x "git status"
  • main.go -o main.png
  • main.go -o main.svg

all worked as expected

Copy link
Member

@aymanbagabas aymanbagabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

@@ -16,7 +16,8 @@ require (
github.com/charmbracelet/log v0.4.0
github.com/charmbracelet/x/ansi v0.4.0
github.com/charmbracelet/x/exp/term v0.0.0-20240403043919-dea9035a27d4
github.com/creack/pty v1.1.23
github.com/charmbracelet/x/term v0.2.0
github.com/charmbracelet/x/xpty v0.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
github.com/charmbracelet/x/xpty v0.1.0
github.com/charmbracelet/x/xpty v0.1.1

Copy link
Member

@aymanbagabas aymanbagabas Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update xpty for this to be applied charmbracelet/x@2bbbfa1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants