-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: using xpty #151
base: main
Are you sure you want to change the base?
fix: using xpty #151
Conversation
Signed-off-by: Carlos Alexandro Becker <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tests pass + tried
-x "git status"
main.go -o main.png
main.go -o main.svg
all worked as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise
@@ -16,7 +16,8 @@ require ( | |||
github.com/charmbracelet/log v0.4.0 | |||
github.com/charmbracelet/x/ansi v0.4.0 | |||
github.com/charmbracelet/x/exp/term v0.0.0-20240403043919-dea9035a27d4 | |||
github.com/creack/pty v1.1.23 | |||
github.com/charmbracelet/x/term v0.2.0 | |||
github.com/charmbracelet/x/xpty v0.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github.com/charmbracelet/x/xpty v0.1.0 | |
github.com/charmbracelet/x/xpty v0.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update xpty for this to be applied charmbracelet/x@2bbbfa1
using x/xpty, and using term size as pty size