feat: Granular progress bar completion #680
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't mind the broken UI... This is just an example to show you guys how a better resolution can make animations smoother and make sliders much more precise/representative ;)
|
|
This is SO good. We'll need to review this properly but I think it's safe to say we should get this one in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A progress cell currently only has two states: complete, incomplete.
This PR let's progress bars be much more granular by having 9 possible states for the bar which drastically increases resolution.
Animations render at 60fps by default. It's a shame to have smoothness limited by progress bar resolution ;)