List hide empty

[mfulz]

Added a setting to list which can hide the "No items" on an empty list

[FFCoder]

I wonder if it would be better to just be called "HideEmptyStatus" rather than "SetHideEmpty"?

[mfulz]

I wonder if it would be better to just be called "HideEmptyStatus" rather than "SetHideEmpty"?

For me personally it doesn't matter, but I was following the other methods like: SetShowHelp, SetShowTitle, etc. which was the most obvious match to me. Especially if thinking of dynamic switching that one on and off, where HideEmptyStatus(false) would seem a bit weird to me :)

[meowgorithm]

So part of me wonders if the API should be something like the following to provide more flexibility around how that empty items message is rendered.

type Model structure {
    EmptyItemsNote func(string) string
}

And by default it would be something like:

m.EmptyItemsNote = func(itemsPlural string) string {
    return fmt.Sprintf("(no %s)", itemsPlural)
}

And to hide it you'd:

m.EmptyItemsNote = nil
m.RemoveEmptyItemsNote() // Maybe also a helper?

[mfulz]

So part of me wonders if the API should be something like the following to provide more flexibility around how that empty items message is rendered.

type Model structure {
    EmptyItemsNote func(string) string
}

And by default it would be something like:

m.EmptyItemsNote = func(itemsPlural string) string {
    return fmt.Sprintf("(no %s)", itemsPlural)
}

And to hide it you'd:

m.EmptyItemsNote = nil
m.RemoveEmptyItemsNote() // Maybe also a helper?

That's a way better idea :)

[meowgorithm]

Okay cool! Do you mind updating accordingly?

[mfulz]

Okay cool! Do you mind updating accordingly?

Done :)

[meowgorithm]

Thank you! This looks good on first glance: we'll give it a proper review shortly.