feat(textinput): expose UpdateSuggestions method
#630
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables clients of the lib to update the suggestions at runtime whenever they please. One direct application of this is when using `m.SetValue()`: After calling it, there is no way to get the updated `m.CurrentSuggestion()` as `m.SetValue()` does not update the suggestion list. It would be possible to also run `m.updateSuggestions()` somewhere in `m.SetValue`, but that might interfere with other things.
nobe4
added a commit
to nobe4/gh-not
that referenced
this pull request
Oct 2, 2024
This prepares later work for #187. Passing parameter will enable additional customization in the REPL and later in the config as well. Only the `Debug` action currently uses this new parameter, to confirm it's receiving it correctly. Also have to do some workaround a bubble limitation, see charmbracelet/bubbles#630
|
I think this make sense, though I do wonder: are they any use cases where we would not want this to be automatically called in |
|
I don't really know if there are usecases against automatically calling it in Typically, the suggestions should be updated when:
So maybe just calling it in In any case I'm happy for either solution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables clients of the lib to update the suggestions at runtime whenever they please.
One direct application of this is when using
m.SetValue(): After calling it, there is no way to get the updatedm.CurrentSuggestion()asm.SetValue()does not update the suggestion list.It would be possible to also run
m.updateSuggestions()somewhere inm.SetValue, but that might interfere with other things.Note
Doing the following would work, but would require some useless re-calculation.
See https://github.com/nobe4/gh-not/pull/188/files#diff-9a8a064fb3b750f10c2ed5e1dde89d98645d2984d15b8b541501b5f6829e32e1R25-R30 for a real-life usage.