test(table): improve table unit tests #601
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broderick-Westrope
changed the title
aymanbagabas
approved these changes
Dec 6, 2024
|
Hi @aymanbagabas, nice to see some activity here. I welcome any questions or change requests you may have :) |
Could you please look into the tests and why they're failing? |
|
@aymanbagabas the tests are failing intentionally. I was tasked with creating tests to validate the correct output. Known bugs are currently making the tests fail. Please see the PR description for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to add unit tests for the
tablecomponent as requested in #593. The hope is that the table bubble will be as thoroughly tested as the lipgloss table.Tests have been added to address these issues:
Tests written specifically for issues will be failing until the issue is fixed (in a separate PR). Other tests have also been added to improve the general coverage (ie. not in relation to any known issue).
I welcome questions relating to this PR. I think this is a great platform for clarifying the expected/desired behaviour of the table component.