Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeleton whitepaper #39

Merged
merged 1 commit into from
Jun 26, 2018
Merged

Skeleton whitepaper #39

merged 1 commit into from
Jun 26, 2018

Conversation

veggiemonk
Copy link
Contributor

@veggiemonk veggiemonk commented Jun 26, 2018

Related to #3

@veggiemonk veggiemonk requested a review from Lawouach June 26, 2018 06:10
@Lawouach
Copy link
Member

Thanks a lot @veggiemonk!

Should we all work on that branch and merge later on? Or should we merge and work from master directly?

(cc @caniszczyk)

@veggiemonk
Copy link
Contributor Author

If we merge it directly, it would be nice to put a message saying that the document is a draft and is changing.
The advantage of having the change directly in master makes the merging is easier (but not always easy in case of multiple edit on the same part).

On the other hand, leaving the change in a branch/PR might slow down the iteration because we don't know when a PR is good enough to be merged.

So I would suggest to merge as fast as possible in master and get comfortable at making small PR that are easy to review and merge.

What do you think?

@caniszczyk
Copy link
Contributor

caniszczyk commented Jun 26, 2018 via email

@caniszczyk caniszczyk merged commit f3a9238 into master Jun 26, 2018
@veggiemonk veggiemonk deleted the whitepaper branch June 26, 2018 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants