Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrating awsssmchaosrunner with chaos-mesh #16

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Integrating awsssmchaosrunner with chaos-mesh #16

wants to merge 9 commits into from

Conversation

Debanitrkl
Copy link

No description provided.

STRRL
STRRL requested changes Apr 13, 2021
View reviewed changes
Copy link
Member

@STRRL STRRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Debanitrkl, I appending some items of drawbacks and alternatives, PTAL. :D

text/2021-04-09-.awsssmchaosrunner integration for AWSChaos.md Outdated Show resolved Hide resolved
text/2021-04-09-.awsssmchaosrunner integration for AWSChaos.md Outdated Show resolved Hide resolved
text/2021-04-09-.awsssmchaosrunner integration for AWSChaos.md Outdated Show resolved Hide resolved
text/2021-04-09-.awsssmchaosrunner integration for AWSChaos.md Show resolved Hide resolved
text/2021-04-09-.awsssmchaosrunner integration for AWSChaos.md Show resolved Hide resolved
@STRRL
Copy link
Member

STRRL commented Apr 13, 2021

Here is a file called npm-debug.log, it is also should not belongs to this PR.

Debanitrkl and others added 8 commits April 13, 2021 09:29
@Debanitrkl
awsssmchaosrunner Integration
cc63599 
Signed-off-by: Debanitrkl <[email protected]>
@Debanitrkl
Updated with design
83fc917 
Signed-off-by: Debanitrkl <[email protected]>
@Debanitrkl
deleted unnecessary files
1803787 
Signed-off-by: Debanitrkl <[email protected]>
@Debanitrkl @STRRL
Update text/2021-04-09-.awsssmchaosrunner integration for AWSChaos.md
347b7bd 
Co-authored-by: STRRL <[email protected]>
Signed-off-by: Debanitrkl <[email protected]>
@Debanitrkl @STRRL
Update text/2021-04-09-.awsssmchaosrunner integration for AWSChaos.md
c7818fd 
Co-authored-by: STRRL <[email protected]>
Signed-off-by: Debanitrkl <[email protected]>
@Debanitrkl @STRRL
Update text/2021-04-09-.awsssmchaosrunner integration for AWSChaos.md
6a07746 
Co-authored-by: STRRL <[email protected]>
Signed-off-by: Debanitrkl <[email protected]>
@Debanitrkl @STRRL
Update text/2021-04-09-.awsssmchaosrunner integration for AWSChaos.md
e0d0e42 
Co-authored-by: STRRL <[email protected]>
Signed-off-by: Debanitrkl <[email protected]>
@Debanitrkl @STRRL
Update text/2021-04-09-.awsssmchaosrunner integration for AWSChaos.md
fc1f20e 
Co-authored-by: STRRL <[email protected]>
Signed-off-by: Debanitrkl <[email protected]>
@AsterNighT
Copy link

I read about awsssmchaosrunner and see familiar functions in chaos-mesh. Any chance that we may intergrate aws chaos in networkchaos and stresschaos and use a different selector?

@AsterNighT
Copy link

https://github.com/amzn/awsssmchaosrunner/blob/e5524eeaef78dca85ac5a9b4a9634efae75df967/src/main/kotlin/software/amazon/awsssmchaosrunner/attacks/DependencyPacketLossAttack.kt#L20

This is a bit weird to me 🤦

@STRRL
Copy link
Member

STRRL commented Apr 13, 2021

Yeah, the core of awsssmchaosrunner is many shell scripts. So I wonder that if we could rewrite it someday.

@Debanitrkl
Removed markdown errors
29a2173 
Signed-off-by: Debanitrkl <[email protected]>
@YangKeao
Copy link
Member

https://github.com/amzn/awsssmchaosrunner/blob/e5524eeaef78dca85ac5a9b4a9634efae75df967/src/main/kotlin/software/amazon/awsssmchaosrunner/attacks/DependencyPacketLossAttack.kt#L20

This is a bit weird to me facepalm

Wow! Really familiar codes 😆

This was referenced Jun 1, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@STRRL STRRL STRRL requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Debanitrkl @STRRL @AsterNighT @YangKeao