Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: chaos engineering as a service #14

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shivanshs9
Copy link

@shivanshs9 shivanshs9 commented Mar 1, 2021

two seperate programs that serve similar purpose.
**Goal is to unify the two.**
2. Poor observability of experiment results from within the dashboard
**Goal is to collect the metrics by Prometheus and show in dashboard.**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe collect the metrics by Prometheus and show in dashboard is just one way of improve the observability. 😃

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WangXiangUSTC What do you suggest we could do besides Prometheus integration for this?

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC Mar 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe some data of the chaos experiment itself. In fact, I don’t have a definite idea yet

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good examples of metrics from Litmus as mentioned in this blog.

I think we must have metrics around pass/fail/awaited for all chaos operations which client is going to perform. We already have one pass metric but we certainly can have more metric around this (like per namespace) to make data more visible and easy to consume.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree with you

@shivanshs9 shivanshs9 changed the title docs: new rfc: chaos engineering as a service RFC: chaos engineering as a service Mar 2, 2021
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, do we need to describe how to control some role's privileges in this RFC?

Comment on lines +55 to +58
Chaosd runs on physic nodes outside kubernetes cluster, so it is vulnerable to attack
from internet. To prevent misuse of chaosd, it needs to allow only authenticated
requests. The easiest and secure setup is to use SSL certificates to both encrypt
the request data and for authentication.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should unit them into one line

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have some problems below

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

umm.. basically combine to one sentence??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to one line

Comment on lines +66 to +69
In this setup, private key of the certificate will be generated and kept with the
dashboard and public key would be stored on chaosd nodes. On any request,
chaosd would first verify the digital signatures presented by the client to
authenticate the request.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question, the private key is kept by client(dashboard),is it looks strange?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For authentication using certificates, the requesting entity must have the private key. Since dashboard will be calling http endpoints of chaosd, it'll have private key

@shivanshs9
Copy link
Author

@WangXiangUSTC that's a discussion in itself since it corresponds to what actions can be taken on the dashboard. I don't have the full clarity on everything so we could probably discuss it in a team meeting?

@WangXiangUSTC
Copy link
Contributor

@WangXiangUSTC that's a discussion in itself since it corresponds to what actions can be taken on the dashboard. I don't have the full clarity on everything so we could probably discuss it in a team meeting?

OK

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants