Wait for server to actually close before resolving promise

chanzuckerberg · Sep 18, 2024 · 12e3ff6 · 12e3ff6
1 parent 25e7a45
commit 12e3ff6
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- [fix] Wait for server to close before ending the test run
+
 ## 8.2.0
 
 - [new] Add parameter for Axe `context` [#98](https://github.com/chanzuckerberg/axe-storybook-testing/pull/98)

diff --git a/src/Server.ts b/src/Server.ts
@@ -62,9 +62,12 @@ async function getServer(options: Options): Promise<Server> {
     });
   }
 
-  function stop() {
-    server.close();
-    return Promise.resolve();
+  function stop(): Promise<void> {
+    return new Promise((resolve) => {
+      server.close(() => {
+        resolve();
+      });
+    });
   }
 
   return {storybookUrl, start, stop};